Re: [PATCH 5/6] am: Fix launching of pager

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2010, 02:30 UTC
Message-ID: <7viq9zw7qa.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100214120731.GE3499@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 24 quoted lines

> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index d56426d..f3b5237 100755
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -107,6 +107,22 @@ git_editor() {
>  	eval "$GIT_EDITOR" '"$@"'
>  }
>  
> +git_pager() {
> +	if test -z "${GIT_PAGER+set}"
> +	then
> +		if tty <&1 >/dev/null 2>/dev/null
> +		then
> +			GIT_PAGER=cat
> +		else
> +			GIT_PAGER=$(git var GIT_PAGER)
> +		fi
> +	fi
> +	: ${LESS=-FRSX}
> +	export LESS
> +
> +	eval "$GIT_PAGER" '"$@"'
> +}
> +

I didn't read other patches, but I think this is a good change.

Acked-by: Junio C Hamano <gitster@pobox.com>