Re: 'git svn log' no longer uses the pager

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 14, 2010, 11:54 UTC
Message-ID: <20100214115430.GA1849@progeny.tock>
In-Reply-To: <20100213235156.GA9054@coredump.intra.peff.net>

Jeff King wrote:

> On Sat, Feb 13, 2010 at 03:14:54PM -0600, Sebastian Celis wrote:

>> Ever since upgrading to git 1.6.6.1 I have noticed that 'git svn log'
>> no longer uses the pager. It definitely used to in git 1.6.5.X, but it
>> no longer does.

[...]

> I think it's a bug. It bisects to Jonathan's dec543e (am -i, git-svn:
> use "git var GIT_PAGER", 2009-10-30). But it seems to me that "git var
> GIT_PAGER" is fundamentally broken.

Yikes, you’re right.  Sorry about that.

> For git-config's colorbool support we have the caller pass in a
> stdout-is-tty flag. I suspect we would need to do the same thing here.

Thanks for the helpful reference. I think it is simpler for the caller to disable the pager himself, i.e., something like patches 2, 4, and 5 below:

Jonathan Nieder (6):
  Fix 'git var' usage synopsis
  Make 'git var GIT_PAGER' always print the configured pager
  git.1: Clarify the behavior of the --paginate option
  git svn: Fix launching of pager
  am: Fix launching of pager
  tests: Add tests for automatic use of pager

 Documentation/git-var.txt |    2 +-
 Documentation/git.txt     |    8 ++-
 builtin-var.c             |    4 +-
 cache.h                   |    2 +-
 git-am.sh                 |    5 +-
 git-sh-setup.sh           |   16 +++++
 git-svn.perl              |    9 ++-
 pager.c                   |    6 +-
 t/t7006-pager.sh          |  163 +++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 200 insertions(+), 15 deletions(-)
 create mode 100644 t/t7006-pager.sh