Re: [PATCH v2 1/6] Fix 'git var' usage synopsis

From: Jeff King <peff@peff.net>
Date: Feb 15, 2010, 04:47 UTC
Message-ID: <20100215044722.GC3336@coredump.intra.peff.net>
In-Reply-To: <20100215023636.GA17444@progeny.tock>

On Sun, Feb 14, 2010 at 08:36:36PM -0600, Jonathan Nieder wrote:

Show 14 quoted lines

> > --- a/builtin-var.c
> > +++ b/builtin-var.c
> > @@ -6,7 +6,7 @@
> >  #include "cache.h"
> >  #include "exec_cmd.h"
> >  
> > -static const char var_usage[] = "git var [-l | <variable>]";
> > +static const char var_usage[] = "git var (-l | <variable>)";
> >  static const char *editor(int flag)
> >  {
> 
> As Junio noticed, this doesn’t apply.  The problem is a missing
> blank line between the static const char var_usage and static const
> char *editor lines.  Worse still, I have no clue how it happened.

I think it was a stray deletion in your editor. The patch is actually corrupt (the hunk claims 7 lines, but contains only 6). And you put text after the "---", so presumably you did so with an editor. So I think it is probably not a bug, but just a weird once-off user error.

Or maybe cosmic rays ate your line feed.

-Peff