Re: [PATCH 2/6] Make 'git var GIT_PAGER' always print the configured pager

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 15, 2010, 05:44 UTC
Message-ID: <20100215054447.GB22121@progeny.tock>
In-Reply-To: <20100215050007.GE3336@coredump.intra.peff.net>

On Mon, Feb 15, 2010 at 12:00:07AM -0500, Jeff King wrote:

> On Sun, Feb 14, 2010 at 05:59:59AM -0600, Jonathan Nieder wrote:

Show 8 quoted lines

>> So avoid tricks with isatty() and just always print the configured
>> pager.
>
> I think this is the right thing to do. But isn't "git am" broken in the
> meantime, as it now always paginates (whereas before, it would never
> paginate)? You fix it later in the series, but is there any test
> breakage in the meantime (not rhetorical, I didn't actually check) that
> would hurt bisectability?

The behavior before dec543 (am -i, git-svn: use "git var GIT_PAGER", 2009-10-30) was to always paginate. This made some sense, since this is the (v)iew command in git am --interactive; whether we check or not, presumably stdout is a terminal. So for git am, this restores the older behavior.

There are unfortunately no tests for am --interactive in the test suite, so test suite runs would detect none of this.

Thank you for your attention to detail. Jonathan