Re: 'git svn log' no longer uses the pager

From: Jeff King <peff@peff.net>
Date: Feb 13, 2010, 23:51 UTC
Message-ID: <20100213235156.GA9054@coredump.intra.peff.net>
In-Reply-To: <462027ff1002131314k62069160h63760fc8316aa43b@mail.gmail.com>

On Sat, Feb 13, 2010 at 03:14:54PM -0600, Sebastian Celis wrote:

Show 6 quoted lines

> Ever since upgrading to git 1.6.6.1 I have noticed that 'git svn log'
> no longer uses the pager. It definitely used to in git 1.6.5.X, but it
> no longer does.
> 
> Is this a recent bug that was introduced? Or was this changed on
> purpose? I definitely preferred the old behavior.

I think it's a bug. It bisects to Jonathan's dec543e (am -i, git-svn: use "git var GIT_PAGER", 2009-10-30). But it seems to me that "git var GIT_PAGER" is fundamentally broken. It calls git_pager, which in turns checks isatty(1). But of course stdout _isn't_ a tty, because we are piping it back to the perl process to read the result of "git var". In other words, I don't see how this ever could have worked.

For git-config's colorbool support we have the caller pass in a stdout-is-tty flag. I suspect we would need to do the same thing here.

-Peff