Re: [PATCH v3 5/6] am: Fix launching of pager
- From
Jeff King <peff@peff.net>
- Date
- Feb 15, 2010, 04:42 UTC
- Message-ID
- <20100215044223.GA3336@coredump.intra.peff.net>
- In-Reply-To
- <20100215032533.GA19230@progeny.tock>
On Sun, Feb 14, 2010 at 09:25:33PM -0600, Jonathan Nieder wrote:
Show 10 quoted lines
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -107,6 +107,25 @@ git_editor() {
> eval "$GIT_EDITOR" '"$@"'
> }
>
> +git_pager() {
> + if test -z "${GIT_PAGER+set}"
> + then
> + if tty <&1 >/dev/null 2>/dev/nullWe seem to use "test -t 1" for this elsewhere, and I don't see us using "tty" anywhere else. It is POSIX, and I tested that even Solaris 8 and AIX 6.1 have it. So I don't think it is a portability issue, but others may know more than I.
-Peff