[PATCH v2 3/2] credential-cache: use child_process.args
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 26, 2020, 21:37 UTC
- Message-ID
- <xmqqzh6ht7fg.fsf_-_@gitster.c.googlers.com>
- In-Reply-To
- <20200826194650.4031087-3-gitster@pobox.com>
As child_process structure has an embedded strvec args for formulating the command line, let's use it instead of using an out-of-line argv[] whose length needs to be maintained correctly.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin/credential-cache.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c index d0fafdeb9e..195335a783 100644 --- a/builtin/credential-cache.c +++ b/builtin/credential-cache.c @@ -42,13 +42,13 @@ static int send_request(const char *socket, const struct strbuf *out) static void spawn_daemon(const char *socket) { struct child_process daemon = CHILD_PROCESS_INIT; - const char *argv[] = { NULL, NULL, NULL }; char buf[128]; int r; - argv[0] = "git-credential-cache--daemon"; - argv[1] = socket; - daemon.argv = argv; + strvec_pushl(&daemon.args, + "credential-cache--daemon", socket, + NULL); + daemon.git_cmd = 1; daemon.no_stdin = 1; daemon.out = -1;