Re: [PATCH v2 0/2] avoid running "git-subcmd" in the dashed form

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 27, 2020, 00:57 UTC
Message-ID: <07f26226-c1cd-494d-899e-d6452ad2751f@gmail.com>
In-Reply-To: <20200826194650.4031087-1-gitster@pobox.com>

On 8/26/2020 3:46 PM, Junio C Hamano wrote:

Show 12 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> I think the cvsexportcommit and transport-helper changes are worth
>> salvaging even if we don't remove builtin binaries, so I'll split
>> them and whip them a bit more into a reasonable shape to be merged
>> to 'next'.  The "break those who say 'git-cat-file'" can be left for
>> future.
> 
> And here it is.
> 
> These two patches are clean-ups that are worth doing whether we
> decide to remove on-disk binaries for the builtin commands.

LGTM.

> I droped the third one, that actually stops users from running
> built-in commands using the dashed form, at least for now.  It can
> be resurrected later if we really wants to propose removal to the
> users, but I am not inclined to make such a proposal right now.

I think that's fine for now. A plan to fully deprecate the dashed forms can come later.

Would an interesting in-between step include removing the dashed forms for builtins that didn't exist in Git 2.0?

Thanks, -Stolee