Re: [PATCH v2 3/2] credential-cache: use child_process.args

From: Jeff King <peff@peff.net>
Date: Aug 27, 2020, 04:14 UTC
Message-ID: <20200827041456.GB3346457@coredump.intra.peff.net>
In-Reply-To: <xmqqzh6ht7fg.fsf_-_@gitster.c.googlers.com>

On Wed, Aug 26, 2020 at 02:37:39PM -0700, Junio C Hamano wrote:

> As child_process structure has an embedded strvec args for
> formulating the command line, let's use it instead of using
> an out-of-line argv[] whose length needs to be maintained
> correctly.

I forgot to mention in my other reply: I think this fails to mention the actual functional change, which is switching from the dashed form to using the "git" wrapper.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.