[PATCH v2 1/2] transport-helper: do not run git-remote-ext etc. in dashed form
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 26, 2020, 19:46 UTC
- Message-ID
- <20200826194650.4031087-2-gitster@pobox.com>
- In-Reply-To
- <20200826194650.4031087-1-gitster@pobox.com>
Running it as "git remote-ext" and letting "git" dispatch to "remote-ext" would just be fine and is more idiomatic.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- transport-helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c index defafbf4c1..c52c99d829 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -128,10 +128,10 @@ static struct child_process *get_helper(struct transport *transport) helper->in = -1; helper->out = -1; helper->err = 0; - strvec_pushf(&helper->args, "git-remote-%s", data->name); + strvec_pushf(&helper->args, "remote-%s", data->name); strvec_push(&helper->args, transport->remote->name); strvec_push(&helper->args, remove_ext_force(transport->url)); - helper->git_cmd = 0; + helper->git_cmd = 1; helper->silent_exec_failure = 1; if (have_git_dir())
-- 2.28.0-454-g5f859b1948