Re: [PATCH] run_command: teach API users to use embedded 'args' more

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2020, 04:30 UTC
Message-ID: <xmqqlfi0sobu.fsf@gitster.c.googlers.com>
In-Reply-To: <20200827042157.GC3346457@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> I've actually considered dropping child_process.argv entirely. Having
> two separate ways to do the same thing gives the potential for
> confusion. But I never dug into whether any existing callers would be
> made worse for it (I kind of doubt it, though; worst case they can use
> strvec_pushv). There are still several left after this patch, it seems.
>
> Likewise for child_process.env_array.

Yup, conversion similar to what I did in this patch may be too trivial for #microproject, but would nevertheless be a good #leftoverbits task. The removal of .argv/.env is not entirely trivial but a good candidate for #microproject.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.