Re: [PATCH v2 3/2] credential-cache: use child_process.args

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2020, 04:31 UTC
Message-ID: <xmqqh7soso9v.fsf@gitster.c.googlers.com>
In-Reply-To: <20200827041328.GA3346457@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Yep, this makes sense. I don't recall any reason to use the dashed form
> back then, but probably it was just that I knew it was a separate
> program. Doing it this way will mean an extra parent "git" process
> hanging around, but I don't think it's that big a deal. We never try to
> kill it by PID, etc (instead we connect to the socket and ask it to
> exit). And anyway, it is becoming a builtin in a parallel topic, so that
> extra process will go away. :)

Yeah, this was discovered when I tentatively merged that "don't run built-in as git-foo" to the tip of seen. Without your slimmed-down topic, it wouldn't have been caught. Likewise for remote-ext.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.