Re: [PATCH v1 2/3] cvsexportcommit: do not run git programs in dashed form

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 26, 2020, 08:02 UTC
Message-ID: <nycvar.QRO.7.76.6.2008260956380.56@tvgsbejvaqbjf.bet>
In-Reply-To: <20200826011718.3186597-3-gitster@pobox.com>

Hi Junio,

On Tue, 25 Aug 2020, Junio C Hamano wrote:

Show 5 quoted lines

> This ancient script runs "git-foo" all over the place.  A strange
> thing is that it has t9200 tests successfully running, even though
> it does not seem to futz with PATH to prepend $(git --exec-path)
> output.  It is tempting to declare that the command must be unused,
> but that is left to another topic.

Not surprising at all: when t9200 runs `git cvsexportcommit`, it actually runs `bin-wrappers/git`, which sets `GIT_EXEC_PATH` to the top-level directory of the Git source code, then calls the `git` executable which in turn will set up the `PATH` to prepend `GIT_EXEC_PATH`, and then look for `git-cvsexportcommit` (which does not exist in `bin-wrappers/`, but in `GIT_EXEC_PATH`). And of course then `git-rev-parse` is found on the `PATH`, too.

Slightly more surprising is that my PR build did not fail. I guess we do test `git svn`, but we skip all CVS-related tests, eh?

Slightly related: it might be a good time to deprecate the CVS-related Git commands...

Ciao, Dscho