Re: [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 17, 2018, 19:48 UTC
- Message-ID
- <xmqqy3bz6h24.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180917194214.GG140909@aiede.svl.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> I'd rather that we revert this change altogether. I have nothing > against a convenient command to do this kind of non build related > cleanup, but it shouldn't be spelled as "make clean".
OK, let's do this for now as I wanted to merge the remainder to 'master' today.
-- >8 -- Subject: Revert "doc/Makefile: drop doc-diff worktree and temporary files on "make clean""
This reverts commit 6f924265a0bf6efa677e9a684cebdde958e5ba06, which started to require that we have an executable git available in order to say "make clean", which gives us a chicken-and-egg problem.
Having to have Git installed, or be in a repository, in order to be able to run an optional "doc-diff" tool is fine. Requiring either in order to run "make clean" is a different story.
Reported by Jonathan Nieder <jrnieder@gmail.com>. --- Documentation/Makefile | 1 - 1 file changed, 1 deletion(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile index 623f1a866d..d079d7c73a 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -331,7 +331,6 @@ clean: $(RM) SubmittingPatches.txt $(RM) $(cmds_txt) $(mergetools_txt) *.made $(RM) manpage-base-url.xsl - '$(SHELL_PATH_SQ)' ./doc-diff --clean $(MAN_HTML): %.html : %.txt asciidoc.conf $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
-- 2.19.0