git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] doc/Makefile: remove tmp-doc-diff on "make clean"

From
Jeff King <peff@peff.net>
Date
Aug 30, 2018, 19:55 UTC
Message-ID
<20180830195546.GA22407@sigill.intra.peff.net>
In-Reply-To
<20180830081202.GA10224@sigill.intra.peff.net>

The tmp-doc-diff directory isn't strictly a build product of the Makefile, since it's only present if you manually run the doc-diff script. But anybody running "make clean" would probably want it to go away.

Suggested-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Jeff King <peff@peff.net>
---
> Another fixup for jk/diff-rendered-docs,[...]

And here's one more. I don't have a strong opinion on this myself, but it seems sensible. I doubt anybody cares overly much about the cost of an extra $(RM) during "make clean" (and if they do, we really ought to consider joining the existing ones into a single invocation).

 Documentation/Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index a42dcfc745..99a349ce9a 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -332,6 +332,7 @@ clean:
 	$(RM) SubmittingPatches.txt
 	$(RM) $(cmds_txt) $(mergetools_txt) *.made
 	$(RM) manpage-base-url.xsl
+	$(RM) -r tmp-doc-diff
 
 $(MAN_HTML): %.html : %.txt asciidoc.conf
 	$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
-- 
2.19.0.rc1.546.g3fcb3c0d7c
Previous: Eric SunshineNext: Eric Sunshine
Message 3 of 25 in “doc-diff: always use oids inside worktree”
  1. doc-diff: always use oids inside worktreeJeff King, Aug 30, 2018
  2. Eric SunshineAug 30, 2018
  3. doc/Makefile: remove tmp-doc-diff on "make clean"Jeff King, Aug 30, 2018
  4. Eric SunshineAug 30, 2018
  5. Eric SunshineAug 30, 2018
  6. Jeff KingAug 30, 2018
  7. 0/3 doc-diff: add "clean" mode & fix portability problemEric Sunshine, Aug 31, 2018
  8. 1/3 doc-diff: fix non-portable 'man' invocationEric Sunshine, Aug 31, 2018
  9. Jeff KingAug 31, 2018
  10. 3/3 doc/Makefile: drop doc-diff worktree and temporary files on "make clean"Eric Sunshine, Aug 31, 2018
  11. Jeff KingAug 31, 2018
  12. Eric SunshineAug 31, 2018
  13. Jonathan NiederSep 17, 2018
  14. Junio C HamanoSep 17, 2018
  15. Jonathan NiederSep 17, 2018
  16. Junio C HamanoSep 17, 2018
  17. Jonathan NiederSep 17, 2018
  18. Jeff KingSep 18, 2018
  19. Eric SunshineSep 17, 2018
  20. Eric SunshineSep 17, 2018
  21. 2/3 doc-diff: add --clean mode to remove temporary working gunkEric Sunshine, Aug 31, 2018
  22. Jeff KingAug 31, 2018
  23. Eric SunshineAug 31, 2018
  24. Junio C HamanoAug 31, 2018
  25. Jeff KingAug 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.