git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 31, 2018, 06:33 UTC
Message-ID
<20180831063318.33373-4-sunshine@sunshineco.com>
In-Reply-To
<20180831063318.33373-1-sunshine@sunshineco.com>

doc-diff creates a temporary working tree (git-worktree) and generates a bunch of temporary files which it does not remove since they act as a cache to speed up subsequent runs. Although doc-diff's working tree and generated files are not strictly build products of the Makefile (which, itself, never runs doc-diff), as a convenience, update "make clean" to clean up doc-diff's working tree and generated files along with other development detritus normally removed by "make clean".

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 Documentation/Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index a42dcfc745..26e268ae8d 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -332,6 +332,7 @@ clean:
 	$(RM) SubmittingPatches.txt
 	$(RM) $(cmds_txt) $(mergetools_txt) *.made
 	$(RM) manpage-base-url.xsl
+	'$(SHELL_PATH_SQ)' ./doc-diff --clean
 
 $(MAN_HTML): %.html : %.txt asciidoc.conf
 	$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
-- 
2.19.0.rc1.352.gb1634b371d
Previous: Jeff KingNext: Jeff King
Message 10 of 25 in “doc-diff: always use oids inside worktree”
  1. doc-diff: always use oids inside worktreeJeff King, Aug 30, 2018
  2. Eric SunshineAug 30, 2018
  3. doc/Makefile: remove tmp-doc-diff on "make clean"Jeff King, Aug 30, 2018
  4. Eric SunshineAug 30, 2018
  5. Eric SunshineAug 30, 2018
  6. Jeff KingAug 30, 2018
  7. 0/3 doc-diff: add "clean" mode & fix portability problemEric Sunshine, Aug 31, 2018
  8. 1/3 doc-diff: fix non-portable 'man' invocationEric Sunshine, Aug 31, 2018
  9. Jeff KingAug 31, 2018
  10. 3/3 doc/Makefile: drop doc-diff worktree and temporary files on "make clean"Eric Sunshine, Aug 31, 2018
  11. Jeff KingAug 31, 2018
  12. Eric SunshineAug 31, 2018
  13. Jonathan NiederSep 17, 2018
  14. Junio C HamanoSep 17, 2018
  15. Jonathan NiederSep 17, 2018
  16. Junio C HamanoSep 17, 2018
  17. Jonathan NiederSep 17, 2018
  18. Jeff KingSep 18, 2018
  19. Eric SunshineSep 17, 2018
  20. Eric SunshineSep 17, 2018
  21. 2/3 doc-diff: add --clean mode to remove temporary working gunkEric Sunshine, Aug 31, 2018
  22. Jeff KingAug 31, 2018
  23. Eric SunshineAug 31, 2018
  24. Junio C HamanoAug 31, 2018
  25. Jeff KingAug 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.