Re: [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem

From: Jeff King <peff@peff.net>
Date: Aug 31, 2018, 20:08 UTC
Message-ID: <20180831200819.GE5120@sigill.intra.peff.net>
In-Reply-To: <20180831063318.33373-1-sunshine@sunshineco.com>

On Fri, Aug 31, 2018 at 02:33:15AM -0400, Eric Sunshine wrote:

Show 7 quoted lines

> This series replaces Peff's solo patch[1] which updates "make clean" to
> remove doc-diff's temporary directory. Rather than imbuing the Makefile
> with knowledge specific to doc-diff's internals, this series adds a
> "clean" mode to doc-diff which removes its temporary worktree and
> generated files, and has "make clean" invoke that instead. It also fixes
> a portability problem which prevented doc-diff from working on MacOS and
> FreeBSD.

Thanks. I left a few comments, but this looks good to me as-is.

-Peff