[PATCH 1/3] doc-diff: fix non-portable 'man' invocation
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 31, 2018, 06:33 UTC
- Message-ID
- <20180831063318.33373-2-sunshine@sunshineco.com>
- In-Reply-To
- <20180831063318.33373-1-sunshine@sunshineco.com>
doc-diff invokes 'man' with the -l option to force "local" mode, however, neither MacOS nor FreeBSD recognize this option. On those platforms, if the argument to 'man' contains a slash, it is automatically interpreted as a file specification, so a "local"-like mode is not needed. And, it turns out, 'man' which does support -l falls back to enabling -l automatically if it can't otherwise find a manual entry corresponding to the argument. Since doc-diff always passes an absolute path of the nroff source file to 'man', the -l option kicks in anyhow, despite not being specified explicitly. Therefore, make the invocation portable to the various platforms by simply dropping -l.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> --- Documentation/doc-diff | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/doc-diff b/Documentation/doc-diff index f483fe427c..c2906eac5e 100755 --- a/Documentation/doc-diff +++ b/Documentation/doc-diff @@ -69,7 +69,7 @@ generate_render_makefile () { printf '%s: %s\n' "$dst" "$src" printf '\t@echo >&2 " RENDER $(notdir $@)" && \\\n' printf '\tmkdir -p $(dir $@) && \\\n' - printf '\tMANWIDTH=80 man -l $< >$@+ && \\\n' + printf '\tMANWIDTH=80 man $< >$@+ && \\\n' printf '\tmv $@+ $@\n' done }
-- 2.19.0.rc1.352.gb1634b371d