Re: [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 17, 2018, 20:43 UTC
Message-ID: <CAPig+cSrvvWn1rd6TcG8H6tGvGDvfNJZE3KnxYazwDTfxAkVeg@mail.gmail.com>
In-Reply-To: <xmqq36u77w7y.fsf@gitster-ct.c.googlers.com>

On Mon, Sep 17, 2018 at 3:36 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
> >> +    '$(SHELL_PATH_SQ)' ./doc-diff --clean
> >
> > This means I need a copy of git in order to run "make clean".  That
> > was never required before.  It makes bootstrapping difficult --- do we
> > really need it?
>
> Gahh, you are absolutely right.  Also "doc-diff --clean", if I am
> reading the code correctly, requires us to be in a Git repository,
> not a tarball extract.
>
> Having to have Git installed, or be in a repository, in order to be
> able to run an optional "doc-diff" tool is fine.  Requiring either
> in order to run "make clean" is a different story.
>
> Thanks for spotting.  We can just prefix the line with '-'?  Or does
> the script badly misbehave (due to lack of CEILING_DIRECTORY) when
> run in a tarball extract inside somebody else's repository?

I did consider this case and felt that it would be reasonable for it to error out and ignore the error if git was missing or if the directory was not a repository. And, I _thought_ I had prefixed the line with "-" to handle just such a case, but apparently I botched it. Oh well.