Re: [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2018, 19:36 UTC
Message-ID: <xmqq36u77w7y.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180917183258.GC140909@aiede.svl.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

>> +	'$(SHELL_PATH_SQ)' ./doc-diff --clean
>
> This means I need a copy of git in order to run "make clean".  That
> was never required before.  It makes bootstrapping difficult --- do we
> really need it?

Gahh, you are absolutely right. Also "doc-diff --clean", if I am reading the code correctly, requires us to be in a Git repository, not a tarball extract.

Having to have Git installed, or be in a repository, in order to be able to run an optional "doc-diff" tool is fine. Requiring either in order to run "make clean" is a different story.

Thanks for spotting. We can just prefix the line with '-'? Or does the script badly misbehave (due to lack of CEILING_DIRECTORY) when run in a tarball extract inside somebody else's repository?