Re: [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"

From: Jeff King <peff@peff.net>
Date: Sep 18, 2018, 17:38 UTC
Message-ID: <20180918173810.GF15470@sigill.intra.peff.net>
In-Reply-To: <xmqqy3bz6h24.fsf@gitster-ct.c.googlers.com>

On Mon, Sep 17, 2018 at 12:48:51PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
> 
> > I'd rather that we revert this change altogether.  I have nothing
> > against a convenient command to do this kind of non build related
> > cleanup, but it shouldn't be spelled as "make clean".
> 
> OK, let's do this for now as I wanted to merge the remainder to
> 'master' today.
> 
> -- >8 --
> Subject: Revert "doc/Makefile: drop doc-diff worktree and temporary files on "make clean""
> 
> This reverts commit 6f924265a0bf6efa677e9a684cebdde958e5ba06, which
> started to require that we have an executable git available in order
> to say "make clean", which gives us a chicken-and-egg problem.
> 
> Having to have Git installed, or be in a repository, in order to be
> able to run an optional "doc-diff" tool is fine.  Requiring either
> in order to run "make clean" is a different story.

Yeah, this seems like the best solution. We started with "can we just rm -rf the temporary directory as part of 'make clean'", which is totally sensible and matches the other bits there. But then it got more complicated. :)

People who use doc-diff can still use "doc-diff --clean", so I don't think much is lost.

Thanks.

-Peff