Re: [PATCH] Revert 'diff-merges: let "-m" imply "-p"'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 8, 2021, 00:42 UTC
- Message-ID
- <xmqqy29chim6.fsf@gitster.g>
- In-Reply-To
- <YQ7MGoNswyZJHjkZ@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> Please don't treat this as an attempt to be argumentative:...
I won't. I asked you what I didn't understand in what you said. Answering the question is not being argumentative ;-)
> What's relevant is not whether the script author was in the wrong or > in the right.
I do not agree with this reasoning at all. Only if vast majority of users incorrectly used the command and the option, we may need to consider such a move as an exception, but not as a general rule.
But "stash list" example shows that "log --first-parent -m" without "-p" in a script has a valid reason, and a change that hurts those who correctly used a command and an option in a way they were intended to do _is_ problematic.
Thanks.