Re: Why doesn't `git log -m` imply `-p`?
- From
Sergey Organov <sorganov@gmail.com>
- Date
- Apr 29, 2021, 12:38 UTC
- Message-ID
- <87im45clkp.fsf@osv.gnss.ru>
- In-Reply-To
- <xmqqwnsl93m3.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 22 quoted lines
> Alex Henrie <alexhenrie24@gmail.com> writes: > >> Why do -c and -cc imply -p, but -m does not? I tried to use both `git >> log -c` and `git log -m` today and was confused when the latter didn't >> produce any output. Could we change this behavior in a future version >> of Git? > > "[alias] lm = log -m" can be used when you only want the logs > > $ git lm maint..master > > or when you want to also view patches your preference is to see all > sides of diffs of merges > > $ git lm -p maint..mater > > but depending on who you are that may be of dubious utility. > > It is best to move on, writing it off as historical accident, and > embrace the new --diff-merges=m option, instead of wasting time on > pondering "why", because accidents do not have to have a deep reason > behind them ;-)
Yep, but --diff-merges=m doesn't imply -p either, though it does produce diff output without -p, for merge commits only.
As the final purpose of all this is to have -m as user-friendly short option, I'd incline to finally let it imply -p, as --diff-merges=m now covers another side of the coin.
What do you think?
-- Sergey Organov