Re: Why doesn't `git log -m` imply `-p`?

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 4, 2021, 20:09 UTC
Message-ID: <6091aa0dee8f4_b34a8208ba@natae.notmuch>
In-Reply-To: <CAMMLpeS4pkP_xRw_qT3mCTP4hS3iLP9TwdDf8LV+3+an9aJ3Hw@mail.gmail.com>

Alex Henrie wrote:

> On Wed, Apr 28, 2021 at 9:22 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Alex Henrie <alexhenrie24@gmail.com> writes:

Show 10 quoted lines

> > It is best to move on, writing it off as historical accident, and
> > embrace the new --diff-merges=m option, instead of wasting time on
> > pondering "why", because accidents do not have to have a deep reason
> > behind them ;-)
> 
> If the behavior is an idiosyncratic accident of dubious utility, let's
> replace it with something that makes sense and is useful :-) If we
> make -m imply -p then no alias is necessary, `git log` would display
> the log without diffs and `git log -m` would display the log with all
> the diffs.

Indeed. Mistakes in the design of the UI should not be carried on forever.

Either all --diff-merges={m,c,cc} imply -p, or none should.

-- 
Felipe Contreras