Re: [PATCH] Revert 'diff-merges: let "-m" imply "-p"'
- From
Sergey Organov <sorganov@gmail.com>
- Date
- Aug 17, 2021, 09:17 UTC
- Message-ID
- <875yw4l9ac.fsf@osv.gnss.ru>
- In-Reply-To
- <xmqqy29chim6.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes: > >> Please don't treat this as an attempt to be argumentative:... > > I won't. I asked you what I didn't understand in what you said. > Answering the question is not being argumentative ;-) > >> What's relevant is not whether the script author was in the wrong or >> in the right. > > I do not agree with this reasoning at all. Only if vast majority of > users incorrectly used the command and the option, we may need to > consider such a move as an exception, but not as a general rule. > > But "stash list" example shows that "log --first-parent -m" without > "-p" in a script has a valid reason, and a change that hurts those > who correctly used a command and an option in a way they were > intended to do _is_ problematic.
The patch never meant to be entirely backward compatible in the first place, and, as far as I can see, "log --first-parent -m" doesn't make sense anymore, since --fist-parent implies -m, that has been settled already.
Thanks, Sergey Organov