Re: [PATCH 01/16] check-non-portable-shell: complain about "test" a/-o instead of &&/||

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2021, 18:36 UTC
Message-ID: <xmqqwnt7cpu2.fsf@gitster.g>
In-Reply-To: <926894000.404076765.1618247601502.JavaMail.zimbra@matthieu-moy.fr>

Matthieu Moy <git@matthieu-moy.fr> writes:

Show 9 quoted lines

> And also in Git's Documentation/CodingGuidelines, which motivates the advice with an example:
>
>      test -n "$x" -a "$a" = "$b"
>
>    is buggy and breaks when $x is "=", but
>
>      test -n "$x" && test "$a" = "$b"
>
>    does not have such a problem.

Good advice to cite Documentation/CodingGuidelines in the log message.

Thanks (and nice to hear from you again ;-).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.