Re: [PATCH v5 06/11] describe tests: convert setup to use test_commit
On 2021-04-23 09:21:10+0200, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> Convert the setup of the describe tests to use test_commit when
> possible. This makes use of the new --annotated-tag option to
s/--annotated-tag/--annotate/
Otherwise, looks correct.
Show 15 quoted lines
> test_commit.
>
> Some of the setup here could simply be removed since the data being
> created wasn't important to any of the subsequent tests, so I've done
> so. E.g. assigning to the "one" variable was always useless, and just
> checking that we can describe HEAD after the first commit wasn't
> useful.
>
> In the case of the "two" variable we could instead use the tag we just
> created. See 5312ab11fbf (Add describe test., 2007-01-13) for the
> initial version of this code. There's other cases here like redundant
> "test_tick" invocations, or the simplification of not echoing "X" to a
> file we're about to tag as "x", now we just use "x" in both cases.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
--
Danh
Đoàn Trần Công Danh <congdanhqx@gmail.com>