Re: [PATCH v4 11/11] test-lib: split up and deprecate test_create_repo()

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Apr 21, 2021, 16:43 UTC
Message-ID: <20210421164357.GZ2947267@szeder.dev>
In-Reply-To: <patch-11.11-311a9dba36-20210421T101156Z-avarab@gmail.com>

On Wed, Apr 21, 2021 at 12:15:16PM +0200, Ævar Arnfjörð Bjarmason wrote:

>  5. Since we don't need to move the .git/hooks directory we don't need

Again: Since we don't need to change directories....

Show 5 quoted lines

>     the subshell here either.
> 
>     See 0d314ce834 for when the subshell use got introduced for the
>     convenience of not having to "cd" back and forth while setting up
>     the hooks.

I think this is worse and even more misleading than even v2 was, for the reasons I mentioned earlier.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.