From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Apr 2021 18:36:37 GMT
Subject: Re: [PATCH 01/16] check-non-portable-shell: complain about "test" a/-o instead of &&/||
Message-ID: <xmqqwnt7cpu2.fsf@gitster.g>
In-Reply-To: <926894000.404076765.1618247601502.JavaMail.zimbra@matthieu-moy.fr>

Matthieu Moy <git@matthieu-moy.fr> writes:

> And also in Git's Documentation/CodingGuidelines, which motivates the advice with an example:
>
>      test -n "$x" -a "$a" = "$b"
>
>    is buggy and breaks when $x is "=", but
>
>      test -n "$x" && test "$a" = "$b"
>
>    does not have such a problem.

Good advice to cite Documentation/CodingGuidelines in the log
message.

Thanks (and nice to hear from you again ;-).