Re: [PATCH 14/16] test-lib-functions: use "return 1" instead of "false"

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2021, 19:31 UTC
Message-ID: <xmqqfszvcna4.fsf@gitster.g>
In-Reply-To: <patch-14.16-b6e9d971b40-20210412T110456Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change a few functions that relied on a "false" being the last
> statement in the function to use an explicit "return 1" like the other
> functions in this file.

While not wrong per-se, this and a few other changes in this series are typical of your multi-patch series that unnecessarily consume reviewer bandwidth that could be better spent on other more important and correctness sensitive steps (like 07/16) in the same series.

You should find a good balance to avoid wearing out and distracting your reviewers---they are the most scarce resource around here that must be shared by other people, not just with other topics of your own.

Thanks.