Re: [PATCH v5 00/11] test-lib.sh: new test_commit args, simplification & fixes

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: May 6, 2021, 16:21 UTC
Message-ID: <YJQXbVYOYPHb5Kd7@danh.dev>
In-Reply-To: <87eeejvpuy.fsf@evledraar.gmail.com>

On 2021-05-06 17:32:01+0200, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines

> 
> On Fri, Apr 23 2021, Ævar Arnfjörð Bjarmason wrote:
> 
> > Changes since v4: Only a commit message change/re-wording per
> > <87v98e1oj7.fsf@evledraar.gmail.com>.
> 
> SZEDER, Eric, Đoàn et al: does this v5 look good to you? Junio's
> suggested in [1] that this needs some final review feedback before
> advancing to 'next'. If you could take a look that would be great!

I have some minor nit-picks here and there, I didn't look into 11/11. Otherwise, I think the series is fine, now.

-- 
Danh

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.