Re: [PATCH v5 07/11] test-lib functions: add --printf option to test_commit

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: May 6, 2021, 16:08 UTC
Message-ID: <YJQUZfbJXuWm+7Yf@danh.dev>
In-Reply-To: <patch-07.11-a0fe0640148-20210423T072006Z-avarab@gmail.com>

On 2021-04-23 09:21:11+0200, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 12 quoted lines

> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 827c8502b10..701518f5fd3 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -173,6 +173,10 @@ debug () {
>  #	Do not call test_tick before making a commit
>  #   --append
>  #	Use ">>" instead of ">" when writing "<contents>" to "<file>"
> +#   --printf
> +#       Use "printf" instead of "echo" when writing "<contents>" to
> +#       "<file>". You will need to provide your own trailing "\n". You
> +#       can only supply the FORMAT for the printf(1), not its ARGUMENT(s).

This is the second appearance of "You" in this file, and it's the first in the usage of test_commit Perhaps:

	Trailing "\n" won't be added automatically. This option
	supports nothing but the FORMAT of printf(1),
	not even its ARGUMENT(s).

Or something along the line.

>  #   --signoff
>  #	Invoke "git commit" with --signoff
>  #   --author <author>

-- 
Danh