Re: [PATCH 08/16] test-lib functions: add --printf option to test_commit

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 15, 2021, 14:52 UTC
Message-ID: <CAPig+cRJ1j_FJcuf-T2xhPhJBWGH0_84SfbZ7V9NbSP+QdJpXQ@mail.gmail.com>
In-Reply-To: <878s5jvl3i.fsf@evledraar.gmail.com>

On Thu, Apr 15, 2021 at 7:33 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines

> On Tue, Apr 13 2021, Junio C Hamano wrote:
> > Eric Sunshine <sunshine@sunshineco.com> writes:
> >> I don't care for `--raw` either but couldn't think of anything better
> >> at the time. But perhaps a name such as `--allow-escapes` would be
> >> clearer, or perhaps not. `--c-style-escapes`?
> >
> > It's printf(1) style escapes ;-)
> >
> So, the conclusion of this thread is let's keep it as --printf?

It was bikeshedding on my part, so I don't feel strongly. As mentioned, I only brought it up because my first thought was to wonder how interpolation would work. One might suggest --printf-escapes or --string-escapes but the audience for this is so narrow (Git developers) that the short and concise --printf is probably preferable.