Re: [PATCH v3 2/6] core.fsyncobjectfiles: batched disk flushes

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2021, 20:33 UTC
Message-ID: <xmqqr1dqzyl7.fsf@gitster.g>
In-Reply-To: <xmqqfsu70x58.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> Perhaps
>
> 	if (value && !strcmp(value, "batch"))
> 		fsync_object_files = FSYNC_OBJECT_FILES_BATCH;
> 	else if (git_config_bool(var, value))
> 		fsync_object_files = FSYNC_OBJECT_FILES_ON;
> 	else
> 		fsync_object_files = FSYNC_OBJECT_FILES_OFF;

By the way, in case it wasn't clear, I do mean strcmp and not strcasecmp. Making these things that are meant to be machine readable tokens to be spelled in different ways in the name of "friendliness" is a disease.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.