Re: [PATCH v3 0/6] Implement a batched fsync option for core.fsyncObjectFiles
- From
- Christoph Hellwig <hch@lst.de>
- Date
- Sep 14, 2021, 05:49 UTC
- Message-ID
- <20210914054926.GA26190@lst.de>
- In-Reply-To
- <pull.1076.v3.git.git.1631590725.gitgitgadget@gmail.com>
On Tue, Sep 14, 2021 at 03:38:39AM +0000, Neeraj K. Singh via GitGitGadget wrote:
Show 6 quoted lines
> NOTE: Based on Christoph Hellwig's comments, the 'batch' mode is not correct > on Linux, since sync_file_range does not provide data integrity guarantees. > There is currently no kernel interface suitable to achieve disk flush > batching as is, but he suggested that he might implement a 'syncfs' variant > on top of this patchset. This code is still useful on macOS and Windows, and > the config documentation makes that clear.
If this series lands I can give the syncfs variant a spin. It might not be the best option for gt hosting services, but I think it will be very helpful for typical developer workstations.