From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 14 Sep 2021 20:33:40 GMT
Subject: Re: [PATCH v3 2/6] core.fsyncobjectfiles: batched disk flushes
Message-ID: <xmqqr1dqzyl7.fsf@gitster.g>
In-Reply-To: <xmqqfsu70x58.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Perhaps
>
> 	if (value && !strcmp(value, "batch"))
> 		fsync_object_files = FSYNC_OBJECT_FILES_BATCH;
> 	else if (git_config_bool(var, value))
> 		fsync_object_files = FSYNC_OBJECT_FILES_ON;
> 	else
> 		fsync_object_files = FSYNC_OBJECT_FILES_OFF;

By the way, in case it wasn't clear, I do mean strcmp and not
strcasecmp.  Making these things that are meant to be machine
readable tokens to be spelled in different ways in the name of
"friendliness" is a disease.

Thanks.