Re: [PATCH v6 3/8] core.fsyncobjectfiles: batched disk flushes

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Sep 25, 2021, 03:15 UTC
Message-ID: <e8244ef1-dbd3-d56d-b9db-1e67114538fa@gmail.com>
In-Reply-To: <543ea3569342165363c1602ce36683a54dce7a0b.1632527609.git.gitgitgadget@gmail.com>

On 25/09/21 06.53, Neeraj Singh via GitGitGadget wrote:

Show 7 quoted lines

> At the end of the entire transaction when unplugging bulk checkin we:
> 1. Issue an fsync against a dummy file to flush the hardware writeback
>     cache, which should by now have processed the tmp-objdir writes.
> 2. Rename all of the tmp-objdir files to their final names.
> 3. When updating the index and/or refs, we assume that Git will issue
>     another fsync internal to that operation. This is not the case today,
>     but may be a good extension to those components.

The 'we' can be stripped because only point 1 and 2 that are subject-inferred, so that subject needs to be explicitly mentioned, like:

```
At the end of ... <snip>.:
1. We issue an fsync ... <snip>.
2. We rename ... <snip>.
3. When ... <snip>, we assume <snip>. (stays same)
```

-- 
An old man doll... just what I always wanted! - Clara