Re: [PATCH v4 3/6] core.fsyncobjectfiles: add windows support for batch mode
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 21, 2021, 23:42 UTC
- Message-ID
- <87ilyt8per.fsf@evledraar.gmail.com>
- In-Reply-To
- <a5b3e21b76208fba130e3313a3e70df45ab392af.1632176111.git.gitgitgadget@gmail.com>
On Mon, Sep 20 2021, Neeraj Singh via GitGitGadget wrote:
Show 17 quoted lines
> +int win32_fsync_no_flush(int fd)
> +{
> + IO_STATUS_BLOCK io_status;
> +
> +#define FLUSH_FLAGS_FILE_DATA_ONLY 1
> +
> + DECLARE_PROC_ADDR(ntdll.dll, NTSTATUS, NtFlushBuffersFileEx,
> + HANDLE FileHandle, ULONG Flags, PVOID Parameters, ULONG ParameterSize,
> + PIO_STATUS_BLOCK IoStatusBlock);
> +
> + if (!INIT_PROC_ADDR(NtFlushBuffersFileEx)) {
> + errno = ENOSYS;
> + return -1;
> + }
> +
> + /* See https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-ntifs-ntflushbuffersfileex */
> + memset(&io_status, 0, sizeof(io_status));See just an informative link to the API docs, or is the comemnt on the memset() in particular. This comment seems like it's just doing a Google/Bing search for you, so maybe better without it?