Re: [PATCH v9 2/9] tmp-objdir: disable ref updates when replacing the primary odb

From: Neeraj Singh <nksingh85@gmail.com>
Date: Nov 16, 2021, 20:38 UTC
Message-ID: <CANQDOddCC7+gGUy1VBxxwvN7ieP+N8mQhbxK2xx6ySqZc6U7-g@mail.gmail.com>
In-Reply-To: <211116.867dd8r2b1.gmgdl@evledraar.gmail.com>

On Mon, Nov 15, 2021 at 11:24 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 15 quoted lines

>
>
> On Mon, Nov 15 2021, Neeraj Singh via GitGitGadget wrote:
>
> >       /*
> >        * This object store is ephemeral, so there is no need to fsync.
> >        */
> > -     int will_destroy;
> > +     unsigned int will_destroy : 1;
> >
> >       /*
> >        * Path to the alternative object store. If this is a relative path,
>
> Why add this as an int in the preceding commit and turn it "unsigned :
> 1" here?

Good catch. I'll fix this. This was an artifact of a previous version where there was another variable here as well.

Thanks, Neeraj

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.