Re: [PATCH 00/29] t: detect and fix broken &&-chains in subshells

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 26, 2018, 19:38 UTC
Message-ID: <xmqqo9fxjq39.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180626073001.6555-1-sunshine@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> The --chain-lint[1] option detects breakage in the top-level &&-chain of
> tests. This series undertakes the more complex task of teaching it to
> also detect &&-chain breakage within subshells. See patch 29/29 for the
> gory details of how that's done.

I first looked at 29/29 and got heavily inclined to reject that step, and then continued reading from 1/29 to around 15/29.

I like these earlier changes that fix existing breakage, of course. I also like many of the changes that simplify and/or modernise the test scripts very much, but they are unusable as-is as long as their justification is "chain-lint will start barfing on these constructs".

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.