git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/29] t: drop subshell with missing &&-chain in favor of simpler construct

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jun 26, 2018, 07:29 UTC
Message-ID
<20180626073001.6555-15-sunshine@sunshineco.com>
In-Reply-To
<20180626073001.6555-1-sunshine@sunshineco.com>

These tests employ a noisy subshell (with missing &&-chain) to feed input into Git commands:

    (echo a; echo b; echo c) | git some-command ...
Drop the subshell in favor of a simple 'printf':
    printf "%s\n" a b c | git some-command ...
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 t/t0090-cache-tree.sh         |  2 +-
 t/t2016-checkout-patch.sh     | 24 ++++++++++----------
 t/t3404-rebase-interactive.sh |  6 ++---
 t/t3701-add-interactive.sh    | 16 +++++++-------
 t/t3904-stash-patch.sh        |  8 +++----
 t/t7105-reset-patch.sh        | 12 +++++-----
 t/t7301-clean-interactive.sh  | 41 +++++++++++++++++------------------
 t/t7501-commit.sh             |  4 ++--
 t/t7610-mergetool.sh          |  8 +++----
 9 files changed, 60 insertions(+), 61 deletions(-)
diff --git a/t/t0090-cache-tree.sh b/t/t0090-cache-tree.sh
index 0c61268fd2..f86cc76c9d 100755
--- a/t/t0090-cache-tree.sh
+++ b/t/t0090-cache-tree.sh
@@ -156,7 +156,7 @@ test_expect_success PERL 'commit --interactive gives cache-tree on partial commi
 		return 44;
 	}
 	EOT
-	(echo p; echo 1; echo; echo s; echo n; echo y; echo q) |
+	printf "%s\n" p 1 "" s n y q |
 	git commit --interactive -m foo &&
 	test_cache_tree
 '
diff --git a/t/t2016-checkout-patch.sh b/t/t2016-checkout-patch.sh
index 9cd0ac4ba3..4dcad0f4a2 100755
--- a/t/t2016-checkout-patch.sh
+++ b/t/t2016-checkout-patch.sh
@@ -20,33 +20,33 @@ test_expect_success PERL 'setup' '
 
 test_expect_success PERL 'saying "n" does nothing' '
 	set_and_save_state dir/foo work head &&
-	(echo n; echo n) | git checkout -p &&
+	printf "%s\n" n n | git checkout -p &&
 	verify_saved_state bar &&
 	verify_saved_state dir/foo
 '
 
 test_expect_success PERL 'git checkout -p' '
-	(echo n; echo y) | git checkout -p &&
+	printf "%s\n" n y | git checkout -p &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
 
 test_expect_success PERL 'git checkout -p with staged changes' '
 	set_state dir/foo work index &&
-	(echo n; echo y) | git checkout -p &&
+	printf "%s\n" n y | git checkout -p &&
 	verify_saved_state bar &&
 	verify_state dir/foo index index
 '
 
 test_expect_success PERL 'git checkout -p HEAD with NO staged changes: abort' '
 	set_and_save_state dir/foo work head &&
-	(echo n; echo y; echo n) | git checkout -p HEAD &&
+	printf "%s\n" n y n | git checkout -p HEAD &&
 	verify_saved_state bar &&
 	verify_saved_state dir/foo
 '
 
 test_expect_success PERL 'git checkout -p HEAD with NO staged changes: apply' '
-	(echo n; echo y; echo y) | git checkout -p HEAD &&
+	printf "%s\n" n y y | git checkout -p HEAD &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
@@ -54,14 +54,14 @@ test_expect_success PERL 'git checkout -p HEAD with NO staged changes: apply' '
 test_expect_success PERL 'git checkout -p HEAD with change already staged' '
 	set_state dir/foo index index &&
 	# the third n is to get out in case it mistakenly does not apply
-	(echo n; echo y; echo n) | git checkout -p HEAD &&
+	printf "%s\n" n y n | git checkout -p HEAD &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
 
 test_expect_success PERL 'git checkout -p HEAD^' '
 	# the third n is to get out in case it mistakenly does not apply
-	(echo n; echo y; echo n) | git checkout -p HEAD^ &&
+	printf "%s\n" n y n | git checkout -p HEAD^ &&
 	verify_saved_state bar &&
 	verify_state dir/foo parent parent
 '
@@ -69,7 +69,7 @@ test_expect_success PERL 'git checkout -p HEAD^' '
 test_expect_success PERL 'git checkout -p handles deletion' '
 	set_state dir/foo work index &&
 	rm dir/foo &&
-	(echo n; echo y) | git checkout -p &&
+	printf "%s\n" n y | git checkout -p &&
 	verify_saved_state bar &&
 	verify_state dir/foo index index
 '
@@ -81,21 +81,21 @@ test_expect_success PERL 'git checkout -p handles deletion' '
 
 test_expect_success PERL 'path limiting works: dir' '
 	set_state dir/foo work head &&
-	(echo y; echo n) | git checkout -p dir &&
+	printf "%s\n" y n | git checkout -p dir &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
 
 test_expect_success PERL 'path limiting works: -- dir' '
 	set_state dir/foo work head &&
-	(echo y; echo n) | git checkout -p -- dir &&
+	printf "%s\n" y n | git checkout -p -- dir &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
 
 test_expect_success PERL 'path limiting works: HEAD^ -- dir' '
 	# the third n is to get out in case it mistakenly does not apply
-	(echo y; echo n; echo n) | git checkout -p HEAD^ -- dir &&
+	printf "%s\n" y n n | git checkout -p HEAD^ -- dir &&
 	verify_saved_state bar &&
 	verify_state dir/foo parent parent
 '
@@ -103,7 +103,7 @@ test_expect_success PERL 'path limiting works: HEAD^ -- dir' '
 test_expect_success PERL 'path limiting works: foo inside dir' '
 	set_state dir/foo work head &&
 	# the third n is to get out in case it mistakenly does not apply
-	(echo y; echo n; echo n) | (cd dir && git checkout -p foo) &&
+	printf "%s\n" y n n | (cd dir && git checkout -p foo) &&
 	verify_saved_state bar &&
 	verify_state dir/foo head head
 '
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 352a52e59d..0dea186289 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -509,7 +509,7 @@ test_expect_success 'interrupted squash works as expected' '
 	one=$(git rev-parse HEAD~3) &&
 	set_fake_editor &&
 	test_must_fail env FAKE_LINES="1 squash 3 2" git rebase -i HEAD~3 &&
-	(echo one; echo two; echo four) > conflict &&
+	printf "%s\n" one two four > conflict &&
 	git add conflict &&
 	test_must_fail git rebase --continue &&
 	echo resolved > conflict &&
@@ -523,10 +523,10 @@ test_expect_success 'interrupted squash works as expected (case 2)' '
 	one=$(git rev-parse HEAD~3) &&
 	set_fake_editor &&
 	test_must_fail env FAKE_LINES="3 squash 1 2" git rebase -i HEAD~3 &&
-	(echo one; echo four) > conflict &&
+	printf "%s\n" one four > conflict &&
 	git add conflict &&
 	test_must_fail git rebase --continue &&
-	(echo one; echo two; echo four) > conflict &&
+	printf "%s\n" one two four > conflict &&
 	git add conflict &&
 	test_must_fail git rebase --continue &&
 	echo resolved > conflict &&
diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
index b170fb02b8..7eec7bb3bb 100755
--- a/t/t3701-add-interactive.sh
+++ b/t/t3701-add-interactive.sh
@@ -46,13 +46,13 @@ test_expect_success 'setup expected' '
 '
 
 test_expect_success 'diff works (initial)' '
-	(echo d; echo 1) | git add -i >output &&
+	printf "%s\n" d 1 | git add -i >output &&
 	sed -ne "/new file/,/content/p" <output >diff &&
 	diff_cmp expected diff
 '
 test_expect_success 'revert works (initial)' '
 	git add file &&
-	(echo r; echo 1) | git add -i &&
+	printf "%s\n" r 1 | git add -i &&
 	git ls-files >output &&
 	! grep . output
 '
@@ -83,13 +83,13 @@ test_expect_success 'setup expected' '
 '
 
 test_expect_success 'diff works (commit)' '
-	(echo d; echo 1) | git add -i >output &&
+	printf "%s\n" d 1 | git add -i >output &&
 	sed -ne "/^index/,/content/p" <output >diff &&
 	diff_cmp expected diff
 '
 test_expect_success 'revert works (commit)' '
 	git add file &&
-	(echo r; echo 1) | git add -i &&
+	printf "%s\n" r 1 | git add -i &&
 	git add -i </dev/null >output &&
 	grep "unchanged *+3/-0 file" output
 '
@@ -102,7 +102,7 @@ test_expect_success 'setup expected' '
 
 test_expect_success 'dummy edit works' '
 	test_set_editor : &&
-	(echo e; echo a) | git add -p &&
+	printf "%s\n" e a | git add -p &&
 	git diff > diff &&
 	diff_cmp expected diff
 '
@@ -127,7 +127,7 @@ test_expect_success 'setup fake editor' '
 
 test_expect_success 'bad edit rejected' '
 	git reset &&
-	(echo e; echo n; echo d) | git add -p >output &&
+	printf "%s\n" e n d | git add -p >output &&
 	grep "hunk does not apply" output
 '
 
@@ -140,7 +140,7 @@ test_expect_success 'setup patch' '
 
 test_expect_success 'garbage edit rejected' '
 	git reset &&
-	(echo e; echo n; echo d) | git add -p >output &&
+	printf "%s\n" e n d | git add -p >output &&
 	grep "hunk does not apply" output
 '
 
@@ -170,7 +170,7 @@ test_expect_success 'setup expected' '
 '
 
 test_expect_success 'real edit works' '
-	(echo e; echo n; echo d) | git add -p &&
+	printf "%s\n" e n d | git add -p &&
 	git diff >output &&
 	diff_cmp expected output
 '
diff --git a/t/t3904-stash-patch.sh b/t/t3904-stash-patch.sh
index 83744f8c93..f32e272786 100755
--- a/t/t3904-stash-patch.sh
+++ b/t/t3904-stash-patch.sh
@@ -29,14 +29,14 @@ test_expect_success 'setup' '
 test_expect_success 'saying "n" does nothing' '
 	set_state HEAD HEADfile_work HEADfile_index &&
 	set_state dir/foo work index &&
-	(echo n; echo n; echo n) | test_must_fail git stash save -p &&
+	printf "%s\n" n n n | test_must_fail git stash save -p &&
 	verify_state HEAD HEADfile_work HEADfile_index &&
 	verify_saved_state bar &&
 	verify_state dir/foo work index
 '
 
 test_expect_success 'git stash -p' '
-	(echo y; echo n; echo y) | git stash save -p &&
+	printf "%s\n" y n y | git stash save -p &&
 	verify_state HEAD committed HEADfile_index &&
 	verify_saved_state bar &&
 	verify_state dir/foo head index &&
@@ -51,7 +51,7 @@ test_expect_success 'git stash -p --no-keep-index' '
 	set_state HEAD HEADfile_work HEADfile_index &&
 	set_state bar bar_work bar_index &&
 	set_state dir/foo work index &&
-	(echo y; echo n; echo y) | git stash save -p --no-keep-index &&
+	printf "%s\n" y n y | git stash save -p --no-keep-index &&
 	verify_state HEAD committed committed &&
 	verify_state bar bar_work dummy &&
 	verify_state dir/foo head head &&
@@ -66,7 +66,7 @@ test_expect_success 'git stash --no-keep-index -p' '
 	set_state HEAD HEADfile_work HEADfile_index &&
 	set_state bar bar_work bar_index &&
 	set_state dir/foo work index &&
-	(echo y; echo n; echo y) | git stash save --no-keep-index -p &&
+	printf "%s\n" y n y | git stash save --no-keep-index -p &&
 	verify_state HEAD committed committed &&
 	verify_state dir/foo head head &&
 	verify_state bar bar_work dummy &&
diff --git a/t/t7105-reset-patch.sh b/t/t7105-reset-patch.sh
index 98b7d7b969..d907b6dd18 100755
--- a/t/t7105-reset-patch.sh
+++ b/t/t7105-reset-patch.sh
@@ -19,20 +19,20 @@ test_expect_success PERL 'setup' '
 
 test_expect_success PERL 'saying "n" does nothing' '
 	set_and_save_state dir/foo work work &&
-	(echo n; echo n) | git reset -p &&
+	printf "%s\n" n n | git reset -p &&
 	verify_saved_state dir/foo &&
 	verify_saved_state bar
 '
 
 test_expect_success PERL 'git reset -p' '
-	(echo n; echo y) | git reset -p >output &&
+	printf "%s\n" n y | git reset -p >output &&
 	verify_state dir/foo work head &&
 	verify_saved_state bar &&
 	test_i18ngrep "Unstage" output
 '
 
 test_expect_success PERL 'git reset -p HEAD^' '
-	(echo n; echo y) | git reset -p HEAD^ >output &&
+	printf "%s\n" n y | git reset -p HEAD^ >output &&
 	verify_state dir/foo work parent &&
 	verify_saved_state bar &&
 	test_i18ngrep "Apply" output
@@ -45,20 +45,20 @@ test_expect_success PERL 'git reset -p HEAD^' '
 
 test_expect_success PERL 'git reset -p dir' '
 	set_state dir/foo work work &&
-	(echo y; echo n) | git reset -p dir &&
+	printf "%s\n" y n | git reset -p dir &&
 	verify_state dir/foo work head &&
 	verify_saved_state bar
 '
 
 test_expect_success PERL 'git reset -p -- foo (inside dir)' '
 	set_state dir/foo work work &&
-	(echo y; echo n) | (cd dir && git reset -p -- foo) &&
+	printf "%s\n" y n | (cd dir && git reset -p -- foo) &&
 	verify_state dir/foo work head &&
 	verify_saved_state bar
 '
 
 test_expect_success PERL 'git reset -p HEAD^ -- dir' '
-	(echo y; echo n) | git reset -p HEAD^ -- dir &&
+	printf "%s\n" y n | git reset -p HEAD^ -- dir &&
 	verify_state dir/foo work parent &&
 	verify_saved_state bar
 '
diff --git a/t/t7301-clean-interactive.sh b/t/t7301-clean-interactive.sh
index 1bf9789c8a..2bc8526f59 100755
--- a/t/t7301-clean-interactive.sh
+++ b/t/t7301-clean-interactive.sh
@@ -107,7 +107,7 @@ test_expect_success 'git clean -id (filter all)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo f; echo "*"; echo; echo c) | \
+	printf "%s\n" f "*" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -129,7 +129,7 @@ test_expect_success 'git clean -id (filter patterns)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo f; echo "part3.* *.out"; echo; echo c) | \
+	printf "%s\n" f "part3.* *.out" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -151,7 +151,7 @@ test_expect_success 'git clean -id (filter patterns 2)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo f; echo "* !*.out"; echo; echo c) | \
+	printf "%s\n" f "* !*.out" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -173,7 +173,7 @@ test_expect_success 'git clean -id (select - all)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo "*"; echo; echo c) | \
+	printf "%s\n" s "*" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -195,7 +195,7 @@ test_expect_success 'git clean -id (select - none)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo; echo c) | \
+	printf "%s\n" s "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -217,7 +217,7 @@ test_expect_success 'git clean -id (select - number)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo 3; echo; echo c) | \
+	printf "%s\n" s 3 "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -239,7 +239,7 @@ test_expect_success 'git clean -id (select - number 2)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo 2 3; echo 5; echo; echo c) | \
+	printf "%s\n" s "2 3" 5 "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -261,7 +261,7 @@ test_expect_success 'git clean -id (select - number 3)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo 3,4 5; echo; echo c) | \
+	printf "%s\n" s "3,4 5" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -282,7 +282,7 @@ test_expect_success 'git clean -id (select - filenames)' '
 
 	mkdir -p build docs &&
 	touch a.out foo.txt bar.txt baz.txt &&
-	(echo s; echo a.out fo ba bar; echo; echo c) | \
+	printf "%s\n" s "a.out fo ba bar" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test ! -f a.out &&
@@ -298,7 +298,7 @@ test_expect_success 'git clean -id (select - range)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo 1,3-4; echo 2; echo; echo c) | \
+	printf "%s\n" s "1,3-4" 2 "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -320,7 +320,7 @@ test_expect_success 'git clean -id (select - range 2)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo 4- 1; echo; echo c) | \
+	printf "%s\n" s "4- 1" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -342,7 +342,7 @@ test_expect_success 'git clean -id (inverse select)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo s; echo "*"; echo -5- 1 -2; echo; echo c) | \
+	printf "%s\n" s "*" "-5- 1 -2" "" c |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -364,7 +364,7 @@ test_expect_success 'git clean -id (ask)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo a; echo Y; echo y; echo no; echo yes; echo bad; echo) | \
+	printf "%s\n" a Y y no yes bad "" |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -386,7 +386,7 @@ test_expect_success 'git clean -id (ask - Ctrl+D)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(echo a; echo Y; echo no; echo yes; echo "\04") | \
+	printf "%s\n" a Y no yes "\04" |
 	git clean -id &&
 	test -f Makefile &&
 	test -f README &&
@@ -408,8 +408,8 @@ test_expect_success 'git clean -id with prefix and path (filter)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(cd build/ && \
-	 (echo f; echo "docs"; echo "*.h"; echo ; echo c) | \
+	(cd build/ &&
+	 printf "%s\n" f docs "*.h" "" c |
 	 git clean -id ..) &&
 	test -f Makefile &&
 	test -f README &&
@@ -431,9 +431,8 @@ test_expect_success 'git clean -id with prefix and path (select by name)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(cd build/ && \
-	 (echo s; echo "../docs/"; echo "../src/part3.c"; \
-	  echo "../src/part4.c";  echo; echo c) | \
+	(cd build/ &&
+	 printf "%s\n" s ../docs/ ../src/part3.c ../src/part4.c "" c |
 	 git clean -id ..) &&
 	test -f Makefile &&
 	test -f README &&
@@ -455,8 +454,8 @@ test_expect_success 'git clean -id with prefix and path (ask)' '
 	mkdir -p build docs &&
 	touch a.out src/part3.c src/part3.h src/part4.c src/part4.h \
 	docs/manual.txt obj.o build/lib.so &&
-	(cd build/ && \
-	 (echo a; echo Y; echo y; echo no; echo yes; echo bad; echo) | \
+	(cd build/ &&
+	 printf "%s\n" a Y y no yes bad "" |
 	 git clean -id ..) &&
 	test -f Makefile &&
 	test -f README &&
diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
index 9dbbd01fc0..589b6cea23 100755
--- a/t/t7501-commit.sh
+++ b/t/t7501-commit.sh
@@ -47,7 +47,7 @@ test_expect_success 'paths and -a do not mix' '
 test_expect_success PERL 'can use paths with --interactive' '
 	echo bong-o-bong >file &&
 	# 2: update, 1:st path, that is all, 7: quit
-	( echo 2; echo 1; echo; echo 7 ) |
+	printf "%s\n" 2 1 "" 7 |
 	git commit -m foo --interactive file &&
 	git reset --hard HEAD^
 '
@@ -293,7 +293,7 @@ test_expect_success PERL 'interactive add' '
 test_expect_success PERL "commit --interactive doesn't change index if editor aborts" '
 	echo zoo >file &&
 	test_must_fail git diff --exit-code >diff1 &&
-	(echo u ; echo "*" ; echo q) |
+	printf "%s\n" u "*" q |
 	(
 		EDITOR=: &&
 		export EDITOR &&
diff --git a/t/t7610-mergetool.sh b/t/t7610-mergetool.sh
index 1a430b9c40..a66d038083 100755
--- a/t/t7610-mergetool.sh
+++ b/t/t7610-mergetool.sh
@@ -57,18 +57,18 @@ test_expect_success 'setup' '
 
 	git checkout -b delete-base branch1 &&
 	mkdir -p a/a &&
-	(echo one; echo two; echo 3; echo 4) >a/a/file.txt &&
+	printf "%s\n" one two 3 4 >a/a/file.txt &&
 	git add a/a/file.txt &&
 	git commit -m"base file" &&
 	git checkout -b move-to-b delete-base &&
 	mkdir -p b/b &&
 	git mv a/a/file.txt b/b/file.txt &&
-	(echo one; echo two; echo 4) >b/b/file.txt &&
+	printf "%s\n" one two 4 >b/b/file.txt &&
 	git commit -a -m"move to b" &&
 	git checkout -b move-to-c delete-base &&
 	mkdir -p c/c &&
 	git mv a/a/file.txt c/c/file.txt &&
-	(echo one; echo two; echo 3) >c/c/file.txt &&
+	printf "%s\n" one two 3 >c/c/file.txt &&
 	git commit -a -m"move to c" &&
 
 	git checkout -b stash1 master &&
@@ -349,7 +349,7 @@ test_expect_success 'mergetool keeps tempfiles when aborting delete/delete' '
 	git checkout -b test$test_count move-to-c &&
 	test_config mergetool.keepTemporaries true &&
 	test_must_fail git merge move-to-b &&
-	! (echo a; echo n) | git mergetool a/a/file.txt &&
+	! printf "%s\n" a n | git mergetool a/a/file.txt &&
 	test -d a/a &&
 	cat >expect <<-\EOF &&
 	file_BASE_.txt
-- 
2.18.0.419.gfe4b301394
Previous: Eric SunshineNext: Junio C Hamano
Message 9 of 123 in “t: detect and fix broken &&-chains in subshells”
  1. 00/29 t: detect and fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  2. 01/29 t7508: use test_when_finished() instead of managing exit code manuallyEric Sunshine, Jun 26, 2018
  3. 03/29 t1300: use sane_unset() to avoid breaking &&-chainEric Sunshine, Jun 26, 2018
  4. 02/29 t0001: use "{...}" block around "||" expression rather than subshellEric Sunshine, Jun 26, 2018
  5. 04/29 t3303: use standard here-doc tag "EOF" to avoid fooling --chain-lintEric Sunshine, Jun 26, 2018
  6. 09/29 t7810: use test_expect_code() instead of hand-rolled comparisonEric Sunshine, Jun 26, 2018
  7. 12/29 t9401: drop unnecessary nested subshellEric Sunshine, Jun 26, 2018
  8. 15/29 t: drop unnecessary terminating semicolons in subshellEric Sunshine, Jun 26, 2018
  9. 14/29 t: drop subshell with missing &&-chain in favor of simpler constructEric Sunshine, Jun 26, 2018
  10. Junio C HamanoJun 26, 2018
  11. Eric SunshineJun 26, 2018
  12. 20/29 t2000-t2999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  13. 18/29 t0000-t0999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  14. 24/29 t5000-t5999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  15. 28/29 t9119: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  16. 29/29 t/test-lib: teach --chain-lint to detect broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  17. Junio C HamanoJun 26, 2018
  18. Eric SunshineJun 26, 2018
  19. Jeff KingJun 26, 2018
  20. Jeff KingJun 26, 2018
  21. Eric SunshineJun 26, 2018
  22. Elijah NewrenJun 26, 2018
  23. Eric SunshineJun 26, 2018
  24. Eric SunshineJun 26, 2018
  25. Jeff KingJun 26, 2018
  26. Eric SunshineJun 26, 2018
  27. Jeff KingJun 28, 2018
  28. Elijah NewrenJun 27, 2018
  29. Johannes SixtJun 27, 2018
  30. Eric SunshineJun 27, 2018
  31. Jeff KingJun 28, 2018
  32. Junio C HamanoJun 26, 2018
  33. 27/29 t9000-t9999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  34. 26/29 t7000-t7999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  35. 25/29 t6000-t6999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  36. 19/29 t1000-t1999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  37. 22/29 t3030: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  38. 23/29 t4000-t4999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  39. 21/29 t3000-t3999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  40. 13/29 t/lib-submodule-update: fix broken "replace submodule must-fail" testEric Sunshine, Jun 26, 2018
  41. t/lib-submodule-update: fix absorbing testStefan Beller, Jun 27, 2018
  42. Eric SunshineJun 27, 2018
  43. 16/29 t: use test_might_fail() instead of manipulating exit code manuallyEric Sunshine, Jun 26, 2018
  44. 17/29 t: use test_must_fail() instead of checking exit code manuallyEric Sunshine, Jun 26, 2018
  45. Luke DiamandJun 26, 2018
  46. Elijah NewrenJun 26, 2018
  47. Eric SunshineJun 26, 2018
  48. Johannes SixtJun 26, 2018
  49. Eric SunshineJun 26, 2018
  50. Johannes SixtJun 26, 2018
  51. 07/29 t7201: drop pointless "exit 0" at end of subshellEric Sunshine, Jun 26, 2018
  52. 08/29 t7400: fix broken "submodule add/reconfigure --force" testEric Sunshine, Jun 26, 2018
  53. Stefan BellerJun 27, 2018
  54. 10/29 t9001: fix broken "invoke hook" testEric Sunshine, Jun 26, 2018
  55. Jonathan TanJun 26, 2018
  56. 11/29 t9104: use "{...}" block around "||" expression rather than subshellEric Sunshine, Jun 26, 2018
  57. 06/29 t6036: fix broken "merge fails but has appropriate contents" testsEric Sunshine, Jun 26, 2018
  58. Elijah NewrenJun 26, 2018
  59. 05/29 t5505: modernize and simplify hard-to-digest testEric Sunshine, Jun 26, 2018
  60. Elijah NewrenJun 26, 2018
  61. Eric SunshineJun 26, 2018
  62. Elijah NewrenJun 26, 2018
  63. Junio C HamanoJun 26, 2018
  64. Eric SunshineJun 26, 2018
  65. Junio C HamanoJun 26, 2018
  66. Jonathan NiederJun 27, 2018
  67. 00/10 detect broken &&-chains in subshellsEric Sunshine, Jul 11, 2018
  68. 03/10 t/chainlint: add chainlint "basic" test casesEric Sunshine, Jul 11, 2018
  69. 04/10 t/chainlint: add chainlint "whitespace" test casesEric Sunshine, Jul 11, 2018
  70. 05/10 t/chainlint: add chainlint "one-liner" test casesEric Sunshine, Jul 11, 2018
  71. 06/10 t/chainlint: add chainlint "nested subshell" test casesEric Sunshine, Jul 11, 2018
  72. 01/10 t/test-lib: teach --chain-lint to detect broken &&-chains in subshellsEric Sunshine, Jul 11, 2018
  73. Junio C HamanoJul 11, 2018
  74. Eric SunshineJul 12, 2018
  75. Jeff KingJul 12, 2018
  76. Eric SunshineJul 12, 2018
  77. Junio C HamanoJul 12, 2018
  78. Jonathan NiederJul 30, 2018
  79. 0/2 subtree: fix &&-chain and simplify tests (Re: [PATCH v2 01/10] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells)Jonathan Nieder, Jul 30, 2018
  80. 1/2 subtree test: add missing && to &&-chainJonathan Nieder, Jul 30, 2018
  81. 2/2 subtree test: simplify preparation of expected resultsJonathan Nieder, Jul 30, 2018
  82. Eric SunshineJul 30, 2018
  83. Jonathan NiederJul 30, 2018
  84. Eric SunshineJul 30, 2018
  85. Jeff KingJul 31, 2018
  86. Eric SunshineJul 31, 2018
  87. Jeff KingJul 31, 2018
  88. Ævar Arnfjörð BjarmasonAug 23, 2018
  89. Eric SunshineAug 23, 2018
  90. 09/10 t/chainlint: add chainlint "complex" test casesEric Sunshine, Jul 11, 2018
  91. 07/10 t/chainlint: add chainlint "loop" and "conditional" test casesEric Sunshine, Jul 11, 2018
  92. 08/10 t/chainlint: add chainlint "cuddled" test casesEric Sunshine, Jul 11, 2018
  93. 10/10 t/chainlint: add chainlint "specialized" test casesEric Sunshine, Jul 11, 2018
  94. 02/10 t/Makefile: add machinery to check correctness of chainlint.sedEric Sunshine, Jul 11, 2018
  95. 0/5 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 7, 2018
  96. 1/5 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 7, 2018
  97. Jeff KingAug 8, 2018
  98. Eric SunshineAug 9, 2018
  99. Jeff KingAug 9, 2018
  100. 2/5 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 7, 2018
  101. 3/5 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 7, 2018
  102. 4/5 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 7, 2018
  103. 5/5 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 7, 2018
  104. Jeff KingAug 8, 2018
  105. Junio C HamanoAug 9, 2018
  106. 0/6 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 13, 2018
  107. 1/6 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 13, 2018
  108. 2/6 chainlint: match 'quoted' here-doc tagsEric Sunshine, Aug 13, 2018
  109. Junio C HamanoAug 13, 2018
  110. Eric SunshineAug 13, 2018
  111. 3/6 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 13, 2018
  112. 4/6 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 13, 2018
  113. 5/6 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 13, 2018
  114. 6/6 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 13, 2018
  115. 0/6 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 15, 2018
  116. 1/6 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 15, 2018
  117. 3/6 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 15, 2018
  118. 4/6 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 15, 2018
  119. 5/6 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 15, 2018
  120. 6/6 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 15, 2018
  121. 2/6 chainlint: match quoted here-doc tagsEric Sunshine, Aug 15, 2018
  122. chainlint: match "quoted" here-doc tagsEric Sunshine, Aug 29, 2018
  123. Junio C HamanoAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.