Re: [PATCH 0/5] chainlint: improve robustness against "unusual" shell coding

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 9, 2018, 00:44 UTC
Message-ID: <xmqq4lg4e5d4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180808225327.GD3902@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I had two minor comments on the first patch. I'll admit my eyes glazed
> over looking at the rest of them, and to make any kind of intelligent
> review I'd need to spend an hour understanding how the sed script works.
> Which frankly, I'm not sure is worth it.

Didn't I make this prediction when we started the "text inspection" approach that it quickly go downhill resulting in unmaintainable mess rather quickly ;-)?

Show 6 quoted lines

> Given the empirical results
> (both on the real code base and the new tests you add) and the low-risk
> nature (it's linting our tests, after all, not code users run), I'd be
> inclined to say it's not making anything worse, and probably making
> things better. We can find out about any further short-comings in the
> wild.

Amen to that.