From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 Jun 2018 19:38:18 GMT
Subject: Re: [PATCH 00/29] t: detect and fix broken &&-chains in subshells
Message-ID: <xmqqo9fxjq39.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180626073001.6555-1-sunshine@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> The --chain-lint[1] option detects breakage in the top-level &&-chain of
> tests. This series undertakes the more complex task of teaching it to
> also detect &&-chain breakage within subshells. See patch 29/29 for the
> gory details of how that's done.

I first looked at 29/29 and got heavily inclined to reject that
step, and then continued reading from 1/29 to around 15/29.  

I like these earlier changes that fix existing breakage, of course.
I also like many of the changes that simplify and/or modernise the
test scripts very much, but they are unusable as-is as long as their
justification is "chain-lint will start barfing on these constructs".