[PATCH 0/2] subtree: fix &&-chain and simplify tests (Re: [PATCH v2 01/10] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells)
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 30, 2018, 19:06 UTC
- Message-ID
- <20180730190612.GB156463@aiede.svl.corp.google.com>
- In-Reply-To
- <20180730181356.GA156463@aiede.svl.corp.google.com>
(resetting cc list) Jonathan Nieder wrote:
> This is causing contrib/subtree tests to fail for me: running "make -C > contrib/subtree test" produces
[...]
> error: bug in the test script: broken &&-chain or run-away HERE-DOC:
[...]
> Ugly quoting, useless use of "cat", etc, aside, I don't think it's > missing any &&. Hints?
Turns out it was missing a && too. :)
These patches are against "master". Ideally this would have come before es/chain-lint-in-subshell. Since this is contrib/, I'm okay with losing bisectability and having it come after, though.
Thoughts of all kinds welcome.
Jonathan Nieder (2): subtree: add missing && to &&-chain subtree: simplify preparation of expected results
contrib/subtree/t/t7900-subtree.sh | 121 ++++++++--------------------- 1 file changed, 31 insertions(+), 90 deletions(-)