git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 06/29] t6036: fix broken "merge fails but has appropriate contents" tests

From
Elijah Newren <newren@gmail.com>
Date
Jun 26, 2018, 08:44 UTC
Message-ID
<CABPp-BG2LJMQs6=hvyhKOdQE=dSwADsCKrkf16_stEVnUZr_vA@mail.gmail.com>
In-Reply-To
<20180626073001.6555-7-sunshine@sunshineco.com>
On Tue, Jun 26, 2018 at 12:29 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 40 quoted lines
> These tests reference non-existent object "c" when they really mean to
> be referencing "C", however, this error went unnoticed due to a broken
> &&-chain later in the test. Fix these errors, as well as the broken
> &&-chains behind which they hid.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>  t/t6036-recursive-corner-cases.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/t/t6036-recursive-corner-cases.sh b/t/t6036-recursive-corner-cases.sh
> index b5621303d6..b32ff8e1db 100755
> --- a/t/t6036-recursive-corner-cases.sh
> +++ b/t/t6036-recursive-corner-cases.sh
> @@ -506,10 +506,10 @@ test_expect_success 'merge of D & E2 fails but has appropriate contents' '
>                 test_line_count = 2 out &&
>
>                 git rev-parse >expect    \
> -                       B:a   E2:a/file  c:a/file   A:ignore-me &&
> +                       B:a   E2:a/file  C:a/file   A:ignore-me &&
>                 git rev-parse   >actual   \
>                         :2:a  :3:a/file  :1:a/file  :0:ignore-me &&
> -               test_cmp expect actual
> +               test_cmp expect actual &&
>
>                 test_path_is_file a~HEAD
>         )
> @@ -533,10 +533,10 @@ test_expect_success 'merge of E2 & D fails but has appropriate contents' '
>                 test_line_count = 2 out &&
>
>                 git rev-parse >expect    \
> -                       B:a   E2:a/file  c:a/file   A:ignore-me &&
> +                       B:a   E2:a/file  C:a/file   A:ignore-me &&
>                 git rev-parse   >actual   \
>                         :3:a  :2:a/file  :1:a/file  :0:ignore-me &&
> -               test_cmp expect actual
> +               test_cmp expect actual &&
>
>                 test_path_is_file a~D^0
>         )

Eek, how did that become c:a/file when it was originally C:a/file? Thanks for spotting the regression and fixing.

Reviewed-by: Elijah Newren <newren@gmail.com>
Previous: Eric SunshineNext: Eric Sunshine
Message 58 of 123 in “t: detect and fix broken &&-chains in subshells”
  1. 00/29 t: detect and fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  2. 01/29 t7508: use test_when_finished() instead of managing exit code manuallyEric Sunshine, Jun 26, 2018
  3. 03/29 t1300: use sane_unset() to avoid breaking &&-chainEric Sunshine, Jun 26, 2018
  4. 02/29 t0001: use "{...}" block around "||" expression rather than subshellEric Sunshine, Jun 26, 2018
  5. 04/29 t3303: use standard here-doc tag "EOF" to avoid fooling --chain-lintEric Sunshine, Jun 26, 2018
  6. 09/29 t7810: use test_expect_code() instead of hand-rolled comparisonEric Sunshine, Jun 26, 2018
  7. 12/29 t9401: drop unnecessary nested subshellEric Sunshine, Jun 26, 2018
  8. 15/29 t: drop unnecessary terminating semicolons in subshellEric Sunshine, Jun 26, 2018
  9. 14/29 t: drop subshell with missing &&-chain in favor of simpler constructEric Sunshine, Jun 26, 2018
  10. Junio C HamanoJun 26, 2018
  11. Eric SunshineJun 26, 2018
  12. 20/29 t2000-t2999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  13. 18/29 t0000-t0999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  14. 24/29 t5000-t5999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  15. 28/29 t9119: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  16. 29/29 t/test-lib: teach --chain-lint to detect broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  17. Junio C HamanoJun 26, 2018
  18. Eric SunshineJun 26, 2018
  19. Jeff KingJun 26, 2018
  20. Jeff KingJun 26, 2018
  21. Eric SunshineJun 26, 2018
  22. Elijah NewrenJun 26, 2018
  23. Eric SunshineJun 26, 2018
  24. Eric SunshineJun 26, 2018
  25. Jeff KingJun 26, 2018
  26. Eric SunshineJun 26, 2018
  27. Jeff KingJun 28, 2018
  28. Elijah NewrenJun 27, 2018
  29. Johannes SixtJun 27, 2018
  30. Eric SunshineJun 27, 2018
  31. Jeff KingJun 28, 2018
  32. Junio C HamanoJun 26, 2018
  33. 27/29 t9000-t9999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  34. 26/29 t7000-t7999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  35. 25/29 t6000-t6999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  36. 19/29 t1000-t1999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  37. 22/29 t3030: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  38. 23/29 t4000-t4999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  39. 21/29 t3000-t3999: fix broken &&-chains in subshellsEric Sunshine, Jun 26, 2018
  40. 13/29 t/lib-submodule-update: fix broken "replace submodule must-fail" testEric Sunshine, Jun 26, 2018
  41. t/lib-submodule-update: fix absorbing testStefan Beller, Jun 27, 2018
  42. Eric SunshineJun 27, 2018
  43. 16/29 t: use test_might_fail() instead of manipulating exit code manuallyEric Sunshine, Jun 26, 2018
  44. 17/29 t: use test_must_fail() instead of checking exit code manuallyEric Sunshine, Jun 26, 2018
  45. Luke DiamandJun 26, 2018
  46. Elijah NewrenJun 26, 2018
  47. Eric SunshineJun 26, 2018
  48. Johannes SixtJun 26, 2018
  49. Eric SunshineJun 26, 2018
  50. Johannes SixtJun 26, 2018
  51. 07/29 t7201: drop pointless "exit 0" at end of subshellEric Sunshine, Jun 26, 2018
  52. 08/29 t7400: fix broken "submodule add/reconfigure --force" testEric Sunshine, Jun 26, 2018
  53. Stefan BellerJun 27, 2018
  54. 10/29 t9001: fix broken "invoke hook" testEric Sunshine, Jun 26, 2018
  55. Jonathan TanJun 26, 2018
  56. 11/29 t9104: use "{...}" block around "||" expression rather than subshellEric Sunshine, Jun 26, 2018
  57. 06/29 t6036: fix broken "merge fails but has appropriate contents" testsEric Sunshine, Jun 26, 2018
  58. Elijah NewrenJun 26, 2018
  59. 05/29 t5505: modernize and simplify hard-to-digest testEric Sunshine, Jun 26, 2018
  60. Elijah NewrenJun 26, 2018
  61. Eric SunshineJun 26, 2018
  62. Elijah NewrenJun 26, 2018
  63. Junio C HamanoJun 26, 2018
  64. Eric SunshineJun 26, 2018
  65. Junio C HamanoJun 26, 2018
  66. Jonathan NiederJun 27, 2018
  67. 00/10 detect broken &&-chains in subshellsEric Sunshine, Jul 11, 2018
  68. 03/10 t/chainlint: add chainlint "basic" test casesEric Sunshine, Jul 11, 2018
  69. 04/10 t/chainlint: add chainlint "whitespace" test casesEric Sunshine, Jul 11, 2018
  70. 05/10 t/chainlint: add chainlint "one-liner" test casesEric Sunshine, Jul 11, 2018
  71. 06/10 t/chainlint: add chainlint "nested subshell" test casesEric Sunshine, Jul 11, 2018
  72. 01/10 t/test-lib: teach --chain-lint to detect broken &&-chains in subshellsEric Sunshine, Jul 11, 2018
  73. Junio C HamanoJul 11, 2018
  74. Eric SunshineJul 12, 2018
  75. Jeff KingJul 12, 2018
  76. Eric SunshineJul 12, 2018
  77. Junio C HamanoJul 12, 2018
  78. Jonathan NiederJul 30, 2018
  79. 0/2 subtree: fix &&-chain and simplify tests (Re: [PATCH v2 01/10] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells)Jonathan Nieder, Jul 30, 2018
  80. 1/2 subtree test: add missing && to &&-chainJonathan Nieder, Jul 30, 2018
  81. 2/2 subtree test: simplify preparation of expected resultsJonathan Nieder, Jul 30, 2018
  82. Eric SunshineJul 30, 2018
  83. Jonathan NiederJul 30, 2018
  84. Eric SunshineJul 30, 2018
  85. Jeff KingJul 31, 2018
  86. Eric SunshineJul 31, 2018
  87. Jeff KingJul 31, 2018
  88. Ævar Arnfjörð BjarmasonAug 23, 2018
  89. Eric SunshineAug 23, 2018
  90. 09/10 t/chainlint: add chainlint "complex" test casesEric Sunshine, Jul 11, 2018
  91. 07/10 t/chainlint: add chainlint "loop" and "conditional" test casesEric Sunshine, Jul 11, 2018
  92. 08/10 t/chainlint: add chainlint "cuddled" test casesEric Sunshine, Jul 11, 2018
  93. 10/10 t/chainlint: add chainlint "specialized" test casesEric Sunshine, Jul 11, 2018
  94. 02/10 t/Makefile: add machinery to check correctness of chainlint.sedEric Sunshine, Jul 11, 2018
  95. 0/5 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 7, 2018
  96. 1/5 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 7, 2018
  97. Jeff KingAug 8, 2018
  98. Eric SunshineAug 9, 2018
  99. Jeff KingAug 9, 2018
  100. 2/5 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 7, 2018
  101. 3/5 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 7, 2018
  102. 4/5 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 7, 2018
  103. 5/5 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 7, 2018
  104. Jeff KingAug 8, 2018
  105. Junio C HamanoAug 9, 2018
  106. 0/6 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 13, 2018
  107. 1/6 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 13, 2018
  108. 2/6 chainlint: match 'quoted' here-doc tagsEric Sunshine, Aug 13, 2018
  109. Junio C HamanoAug 13, 2018
  110. Eric SunshineAug 13, 2018
  111. 3/6 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 13, 2018
  112. 4/6 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 13, 2018
  113. 5/6 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 13, 2018
  114. 6/6 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 13, 2018
  115. 0/6 chainlint: improve robustness against "unusual" shell codingEric Sunshine, Aug 15, 2018
  116. 1/6 chainlint: match arbitrary here-docs tags rather than hard-coded namesEric Sunshine, Aug 15, 2018
  117. 3/6 chainlint: recognize multi-line $(...) when command cuddled with "$("Eric Sunshine, Aug 15, 2018
  118. 4/6 chainlint: let here-doc and multi-line string commence on same lineEric Sunshine, Aug 15, 2018
  119. 5/6 chainlint: recognize multi-line quoted strings more robustlyEric Sunshine, Aug 15, 2018
  120. 6/6 chainlint: add test of pathological case which triggered false positiveEric Sunshine, Aug 15, 2018
  121. 2/6 chainlint: match quoted here-doc tagsEric Sunshine, Aug 15, 2018
  122. chainlint: match "quoted" here-doc tagsEric Sunshine, Aug 29, 2018
  123. Junio C HamanoAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.