Re: [PATCH 29/29] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 26, 2018, 21:09 UTC
- Message-ID
- <xmqqy3f1i7bi.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180626201708.GA2341@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> One way this series might be worse in practice is that we tend not to > change process state too much outside of the subshells. > ... > Whereas once you start collapsing subshells into the main logic chain, > there's a very high chance that the subshell is doing a "cd", since > that's typically the main reason for the subshell in the first place.
Exactly. I should have mentioned this when I responded to save a round-trip.