Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 26, 2018, 21:00 UTC
Message-ID: <07314f8f-e242-b9b9-fd20-7e1ef8df8e47@kdbg.org>
In-Reply-To: <CAPig+cRnbW9fRh68ZorNQHjDFHQBWmqfEPSO+H7qgMJVOcbJmQ@mail.gmail.com>

Am 26.06.2018 um 20:14 schrieb Eric Sunshine:

Show 9 quoted lines

> On Tue, Jun 26, 2018 at 2:06 PM Johannes Sixt <j6t@kdbg.org> wrote:
>> Hence, these lines should actually be
>>
>>                  p4 help client &&
>>                  ! p4 help nosuchcommand
> 
> Thanks for the comment; you're right, of course. I'll certainly make
> this change if I have to re-roll for some other reason, but do you
> feel that this itself is worth a re-roll?

Not worth a re-roll IMO.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.