Re: [PATCH 5/8] git-prompt: add some missing quotes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 23, 2024, 19:40 UTC
- Message-ID
- <xmqqjzhb28yc.fsf@gitster.g>
- In-Reply-To
- <4f77b7eb7f1110e47201b8c97c34a0cbcd14e24f.1721762306.git.gitgitgadget@gmail.com>
"Avi Halachmi (:avih) via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> From: "Avi Halachmi (:avih)" <avihpit@yahoo.com> > > The issues which this commit fixes are unlikely to be broken > in real life, but the fixes improve correctness, and would prevent > bugs in some uncommon cases, such as weird IFS values. > > Listing some portability guideline here for future reference. > > I'm leaving it to someone else to decide whether to include > it in the file itself, place is as a new file, or not.
Check Documentation/CodingGuidelines; I think we have something to say about local var="val" construct to help dash.
We allowed liberal uses of bash-ism in this file, as it was initially written for bash anyway. If we were rewriting the prompt scripts to be usable by other shells, great. But then we'd want to make sure it adheres to existing coding guidelines we have.