Re: [PATCH 0/8] git-prompt: support more shells
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jul 23, 2024, 22:50 UTC
- Message-ID
- <ZqAzpYuTrK6L-uyN@tapette.crustytoothpaste.net>
- In-Reply-To
- <pull.1750.git.git.1721762306.gitgitgadget@gmail.com>
On 2024-07-23 at 19:18:18, Avi Halachmi via GitGitGadget wrote:
Show 8 quoted lines
> Before this patchset only bash and zsh were supported.
>
> After this patchset, the following shells work: bash, zsh, dash (since at
> least 0.5.8), free/net bsd sh, busybox-ash, mksh, openbsd sh, pdksh(!),
> Schily extended Bourne sh (bosh), yash.
>
> The code should now be almost posix-compliant, with one big exception
> ("local" variables in functions) which is not simple to fix.We explicitly allow `local` in our coding guidelines. As a side note, Debian requires it of all shells that can be used as `/bin/sh`.
> Shells which don't work, likely only due to missing "local": ksh93[u+m], > Schily minimal posix Bourne sh (pbosh), yash-posix-mode.
ksh93u+m is planning on adding local in a future revision.
-- brian m. carlson (they/them or he/him) Toronto, Ontario, CA