Re: [PATCH v2 0/8] git-prompt: support more shells v2
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 16, 2024, 08:50 UTC
- Message-ID
- <Zr8SyWSHH1lAfyuc@tanuki>
- In-Reply-To
- <xmqq7cchtyfc.fsf@gitster.g>
On Thu, Aug 15, 2024 at 11:48:23AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> "Avi Halachmi via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > This addresses review comment on part 6/8 (git-prompt: add fallback for > > shells without $'...') which requested to use one form for all shells > > instead $'...' where supported and a fallback otherwise. > > I've read the series and they looked all sensible. Will queue but > I'd appreciate a second set of eyes before marking it for 'next'.
I did have a look, but honestly I wouldn't consider that to be a qualified review. POSIX shell tends to get borderline unreadable, so I don't want to claim to understand everything I've read.
In any case, I didn't spot anything grave.
Patrick